Starting AI/ML section in python docs [3rd attempt] #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
August 11, 2020 15:30
Removed: * 3D scatter * Splom
Added a preliminary section that introduces roc curves
Added loadings, moved high-dimensional analysis first
TODO: Add thumbnail, references, description of sections
7 tasks
|
@nicolaskruchten I am unable to add the |
|
Unable how? |
|
I'm not sure. I can't push when it is added. |
|
I'll try again tomorrow |
|
@nicolaskruchten Seems like it worked now. Not sure what happened, but it's ready to review now. |
|
OK, this looks really good, thanks for the updates! I went through and fixed a bunch of random little things. Let's see what the CI run looks like in a few minutes and I can try to fix it up and merge this stuff. |
|
OK this is pretty great, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st attempt: #2172
2nd attempt: #2276
Original Issue: #2153
Had to make a new PR since I messed up the branch with unresolved conflicts after rebasing on
doc-prod. This one should be fine (hopefully).Changes:
Todo list: