honor zmin/zmid/zmax in annotated_heatmap font colors #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensdm
reviewed
Nov 27, 2020
| @@ -189,6 +189,23 @@ def __init__( | |||
| self.reversescale = reversescale | |||
| self.font_colors = font_colors | |||
|
|
|||
| if np and isinstance(self.z, np.ndarray): | |||
| self.zmin = np.amin(self.z) | |||
| self.zmax = np.amax(self.z) | |||
There was a problem hiding this comment.
I think we should use np.nanmin and np.nanmax
bensdm
reviewed
Nov 27, 2020
| annotations = [] | ||
| for n, row in enumerate(self.z): | ||
| for m, val in enumerate(row): | ||
| font_color = min_text_color if val < z_mid else max_text_color | ||
| font_color = min_text_color if val < self.zmid else max_text_color |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2892 to close #2187, cc @bensdm.
This is a more targeted fix for the zmin/zmax problem specifically, and doesn't address the difficulty of light colors in the middle range of a diverging colorscale.