Cleaner import checking #317
Closed
+2,191
−2,174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* line too long * bad line breaking at operators (e.g., `*`) * continuation line over-intented
Note that default arguments are used in all function calls. This means that you can get some unexpected storage of previous defaults! It’s best practice not to do this.
IDEs hate this… besides, this is internal code. The important part is that we eventually validate our work by instantiating a `Figure`. We can use the publicly hidden `GraphObjectFactory` for this purpose.
This is a stand-alone module to the following: * Don’t import things until we need them * Keep all the information centralized * No possibility of circular imports by using this module
|
@chriddyp @cldougl @etpinard does this seem reasonable? I'm just using This is the important commit if you feel like checking this out 7cbd355 Chris, I'm trying to follow your momentum with untangling plot_options logic. I think there's a lot more work to be done 😅 |
Merged
|
I'm going to try and revisit this one if I end up with some quiet weekends. The way we currently do optional imports is sorta frustrating. 7cbd355 introduces a new way to tap into the |
|
Woo. Done in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2: Use a single, central place to check whether optional deps are imported and get them from a central source.
(WIP still based off another cleanup branch #316)
This attempts to de-uglify how we do protected imports. One module to rule them all 💍
Todo: