Skip to content

bumping to JS 2.0.0 RC 2 #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
17 changes: 2 additions & 15 deletions contributing.md
Original file line number Diff line number Diff line change
@@ -166,19 +166,6 @@ and
[`pip`](https://pip.pypa.io/en/stable/reference/pip_install/#install-editable)
documentation on _development mode_.

### ipywidgets development install

Run the following commands in your virtual environment to use the
development version of `FigureWidget`,
```bash
(plotly_dev) $ jupyter nbextension enable --py widgetsnbextension
(plotly_dev) $ jupyter nbextension install --py --symlink --sys-prefix plotlywidget
(plotly_dev) $ jupyter nbextension enable --py --sys-prefix plotlywidget
```
To make plotly plots show up in JupyterLab, you also need to [install the plotly jupyterlab extensions][plotly-jl].

[plotly-jl]: https://plot.ly/python/getting-started/#jupyterlab-support-python-35

### Configure black code formatting

This repo uses the [Black](https://black.readthedocs.io/en/stable/) code formatter,
@@ -224,7 +211,7 @@ make that pull request!


## Update to a new version of Plotly.js
First update the version of the `plotly.js` dependency in `packages/javascript/plotlywidget/package.json`.
First update the version of the `plotly.js` dependency in `packages/javascript/jupyterlab-plotly/package.json`.

Then run the `updateplotlyjs` command with:

@@ -238,7 +225,7 @@ the `plotly/plotly.js` GitHub repository (and place them in
`plotly/package_data`). It will then regenerate all of the `graph_objs`
classes based on the new schema.

For dev branches, it is also possible to use `updateplotlyjsdev --devrepo reponame --devbranch branchname` to update to development versions of `plotly.js`. This will fetch the `plotly.js` in the CircleCI artifact of the branch `branchname` of the repo `reponame`. If `--devrepo` or `--devbranch` are omitted, `updateplotlyjsdev` defaults using `plotly/plotly.js` and `master` respectively.
For dev branches, it is also possible to use `updateplotlyjsdev --devrepo reponame --devbranch branchname` to update to development versions of `plotly.js`. This will fetch the `plotly.js` in the CircleCI artifact of the branch `branchname` of the repo `reponame`. If `--devrepo` or `--devbranch` are omitted, `updateplotlyjsdev` defaults using `plotly/plotly.js` and `master` respectively.

## Testing

2 changes: 1 addition & 1 deletion doc/requirements.txt
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ networkx
squarify
scikit-image==0.18.1
scikit-learn
sphinx
sphinx==3.5.4
sphinx_bootstrap_theme
recommonmark
pathlib
Loading