Catch ImportError instead of Exception for FigureWidget #3995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`distutils.version` is deprecated. When using the `FigureWidget` in unit tests with `pytest` where warnings are promoted to errors, the warning becomes an error and the error message is that we have to install `ipywidgets>=7.0.0`, even if `ipywidgets` is installed in the current environment.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutilsis deprecated. When using theFigureWidgetin unit tests withpytestwhere warnings are promoted to errors, the warning becomes an error and the confusing error message is that we have to installipywidgets>=7.0.0, even ifipywidgetsis installed in the current environment.This occurs because the
try/exceptblock is catching all exceptions, instead of just theImportErrorwhich would be the error raised ifipywidgetswas unavailable.Alternatively, we could replace the
LooseVersionwithpackaging.version, but I am not sure if this has wider implications.