fix: Setting category_orders was leading to missing data #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
fix-category-orders
branch
from
b0a57f6 to
ad2c0a5
Compare
emilykl
reviewed
Nov 14, 2024
| if len(single_group_name) == len(grouper): | ||
| # we have a single group, so we can skip all group-by operations! | ||
| groups = {tuple(single_group_name): df} | ||
| else: | ||
| required_grouper = list(orders.keys()) | ||
| required_grouper = [ | ||
| key for key in orders if key in grouper and key != one_group |
There was a problem hiding this comment.
I believe one_group will never be in orders so this can be simplified to
Suggested change
| key for key in orders if key in grouper and key != one_group | |
| key for key in orders if key in grouper |
emilykl
reviewed
Nov 14, 2024
packages/python/plotly/plotly/tests/test_optional/test_px/test_px.py
Outdated
Show resolved
Hide resolved
…_px.py Co-authored-by: Emily KL <[email protected]>
emilykl
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Looks good to me @MarcoGorelli , thanks for the quick fix. 🙌 🚀
@LiamConnors Can you confirm this change fixes the issue for you?
|
thanks for your review! sorry for the repeated pushes, kept noticing minor improvements |
|
Thanks Marco! Apologies for messing this one up 🥲 |
|
Looks good to me too. Thanks @MarcoGorelli ! |
|
No worries @FBruzzesi , you've just discovered we didn't have a test for this case! |
emilykl
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4875
The bug in https://github.com/plotly/plotly.py/pull/4790/files was the change
and in the linked issue #4875, the group
'day'appears inordersbut not inrequired_grouperI've added a test - here's a visual demo too:
Output is also unchanged (compared with the latest PyPI release) when multiple groups point to the same column: