Skip to content

Add back in express extra dependencies and required dependencies #5044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Add back in express extra dependencies and required dependencies #5044

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab90b80
Add back in express extra dependencies and required dependencies
marthacryan Feb 18, 2025
75b5106
Remove deleted files from MANIFEST.in
marthacryan Feb 18, 2025
45a8fca
Update pyproject.toml
marthacryan Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
include LICENSE.txt
include README.md
include requires-install.txt
include requires-express.txt
include plotly/package_data/widgetbundle.js
9 changes: 7 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,14 @@ classifiers = [
requires-python = ">=3.8"
license = {file="LICENSE.txt"}
version = "6.0.0"
dynamic = ["dependencies"]
dependencies = [
"narwhals>=1.13.3",
"packaging"
]

[project.optional-dependencies]
express = ["numpy"]

# TODO: check that this works
[tool.setuptools.packages.find]
where = ["."]
include = ["plotly*", "_plotly*"]
Expand Down
8 changes: 0 additions & 8 deletions requires-express.txt
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions requires-install.txt
View file
Open in desktop

This file was deleted.