Skip to content

feat: restore type checking portion of code generation #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: restore type checking portion of code generation #5198

wants to merge 1 commit into from

Conversation

gvwilson
Copy link
Contributor

@gvwilson gvwilson commented May 22, 2025 •
edited
Loading

@gvwilson
feat: restore type checking portion of code generation
00a1b56 
-   Restore code removed in #4978.
-   (Partially) closes #5186.
@gvwilson gvwilson requested a review from emilykl May 22, 2025 18:57
@gvwilson gvwilson self-assigned this May 22, 2025
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken regression this used to work labels May 22, 2025
gvwilson added a commit that referenced this pull request May 22, 2025
@gvwilson
feat: restore type checking support in generated code
848f68e 
-   Restore code removed in #4978.
-   Finishes closing #5186.
-   Depends on #5198.
@gvwilson gvwilson mentioned this pull request May 22, 2025
Open
emilykl
emilykl approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Along with #5199 this seems to fix syntax highlighting in VSCode on my machine.

alexcjohnson
alexcjohnson reviewed May 23, 2025
View reviewed changes
codegen/utils.py
{repr(rel_classes)}
)
from typing import TYPE_CHECKING
if sys.version_info < (3, 7) or TYPE_CHECKING:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need sys.version_info < (3, 7) anymore - our minimum is past that. Which means we may not need import sys anymore either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson left review comments

@emilykl emilykl emilykl approved these changes

Assignees

@gvwilson gvwilson

Labels
fix fixes something broken P1 needed for current cycle regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v6.1.0 breaks Pylance highlighting and produces errors
3 participants
@gvwilson @alexcjohnson @emilykl