Skip to content

manage plotly/colors.py and plotly/figure_factory/utils.py #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Nov 13, 2017

Currently a couple figure factories are using incorrect plotly colorscales.

A PR to ensure that:

  • the correct plotly colorscales are being used by all figure factories
  • functions for color manipulating/handling are only in the colors.py module
  • rewritting some figure_factory code to comply with correct colorscales

@jonmmease
Copy link
Contributor

@Kully Is there anything here that we should pick back up?

@Kully
Copy link
Contributor Author

Kully commented Sep 28, 2018

Is there anything here that we should pick back up?

yes

so the original plan was to organize utils and colors files in the figure_factory folder. There are some duplicates functions across the two folders and some figure factory modules use function A from one file but function A from the other.

@Kully
Copy link
Contributor Author

Kully commented Nov 20, 2018

closing in favour of #1279

@Kully Kully closed this Nov 20, 2018
@Kully Kully deleted the manage-colors branch November 20, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants