Skip to content

Fix contributing typos #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2022
+7 −5
Merged

Fix contributing typos #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837016a
fix typos
mfreeborn May 9, 2022
b1449e5
update changelog
mfreeborn May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -7,8 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.8.0] - 2022-xx-xx
### Added
### Changed
- Improve implementation of private::NumOrString to support more primitive types ([Issue
- Improve implementation of `private::NumOrString` to support more primitive types ([Issue
#47](https://github.com/igiagkiozis/plotly/issues/47))
### Fixed
- Typos in `CONTRIBUTING.md`
### Updated
- `ndarray` to `0.15.4`.
- `serde` to `1.0.132`.
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ Verifiable example].
[Minimal, Complete, and Verifiable example]: https://stackoverflow.com/help/mcve

When making a feature request, please make it clear what problem you intend to
solve with the feature, any ideas for how Serde could support solving that
solve with the feature, any ideas for how Plotly.rs could support solving that
problem, any possible alternatives, and any disadvantages.

## Process
@@ -27,11 +27,11 @@ appropriately the [change log](CHANGELOG.md).

For change-log updates please use previous entries as reference, namely classify
the nature of the change, e.g. fixed, changed, added etc., and a brief description. The entry in the change-log that should be
used for the update will always be marked with YEAR-XX-XX, e.g. 2020-XX-XX.
used for the update will always be marked with YEAR-XX-XX, e.g. 2022-XX-XX.

Check that the test suite passes locally and that all examples still execute and produce the expected results before submitting a pull request.

Make a pull request with our changes directly to the `dev` branch. Please note, pull requests to the `master` branch will not
Make a pull request with your changes directly to the `dev` branch. Please note, pull requests to the `master` branch will not
be considered. The `master` branch is reserved for release.


@@ -47,4 +47,4 @@ In all forums, we follow the [Rust Code of Conduct]. For escalation or moderatio

## Attribution

Parts of this document are adapted from the [serde](https://github.com/serde-rs/serde) contributing guide.
Parts of this document are adapted from the [serde](https://github.com/serde-rs/serde) contributing guide.