boxmode, barmode, violinmode, etc #551
Conversation
|
Two things:
|
src/__percy__/panels.percy.js
Outdated
| @@ -14,6 +14,8 @@ import './percy.css'; | |||
| * To specify which panels to test with the mock, add entry to panelsToTest, else all panels will be tested | |||
| */ | |||
| const panelsToTest = { | |||
| bar: ['GraphCreatePanel', 'StyleTracesPanel'], | |||
| box: ['GraphCreatePanel', 'StyleTracesPanel'], | |||
There was a problem hiding this comment.
how come histogram doesn't have StyleTracesPanel? can we add that plz?
nicolaskruchten
changed the title
|
I left "Box Mean" in a section of its own - didn't know where else to stick it. Maybe he'll find a friend later as we add more fields. |
|
Somehow "whisker width" no longer appears in Percy now |
|
Also, whisker width should be a numeric fraction I think. |
|
💃 once those whisker issues are taken care of |
|
Oh I see the problem. I'd forgotten that the section I'd asked you to move it into was layout-connected. tricksy tricksy. Maybe we should just leave it in its own little section then like it was before. |
|
but just leaving it not in a section is probably fine too. |
|
Yeah, I know it's totally a hack. But seems to work, so I guess we'll worry about it when it gives us trouble? |
Closes #543
Closes #540
Closes #553
Addresses #505