-
-
Notifications
You must be signed in to change notification settings - Fork 137
Full update on Plot data change #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Regarding point 1: we recently (2 days ago) updated the behaviour of this component and the documentation such that this type of |
Regarding point 2: issue #25 has been closed and we will not be implementing any way of getting to |
Regarding your specific issue: it sounds like there is some odd or incorrect or undesirable behaviour happening with rerendering zoomed plots, which I can investigate for you! Can you create a CodePen showing your issue? |
Thanks. Sorry I got confused with between what I was reading here and on on sites. Glad you made the update, it is very useful. Sure...I will get something setup and send it along |
I apologize that the documentation has been confusing or overly complicated... We're working to streamline things every day :) |
No need to apologise, not at all. I really only asked to make sure I was not missing something critical that might bite me later. I love the fact that you made this change, it makes things much simpler. Rereading your documentation, it is now very clear. It was more that I had read old issues and very likely read the documentation right before you updated it, so had gotten myself a bit confused. Thanks for the quick response. |
Thanks for the validation that the new way is clearer :) I'm definitely interested in following up on the zoom behaviour still though! |
Sure..just took me a bit to get the codepen working: https://codepen.io/robowen5mac/pen/GxgZJE?editors=0010 Click on any point and it should set a blue circle at the spot. If you zoom in and do the same thing, the plot resets. Thanks for the help. |
Ah I see. Well, this makes a certain amount of sense: the Does that make sense? |
Yep, I had started to go down that road, but when I read about Plotly.react, I wasn't sure how much of this state management I still had to do. Thanks for the clarification and help |
No problem! Please let me know how you make out. There clearly isn't enough documentation in the ReadMe of this component about how much of this is necessary... |
Done, easy change. Working just as I wanted it to now. |
Great! I'll try to update the documentation to make it a bit clearer that this is now a "dumb" component that doesn't preserve its internal state. |
I've just updated the documentation to make this clearer :) |
Hey, everyone! Take a look in this solution with explanations in how to create a graph using React and Plot.ly with the life cycle of the React. https://medium.com/@jmmccota/plotly-react-and-dynamic-data-d40c7292dbfb |
I am just starting to work with Plotly as a part of a create react app based project an I wanted to ask a few clarifying questions (plotly.js 1.35.1 and react-plotly.js 1.7.0)
Based on all the documentation I have read and the demo application itself, one needs to eject or directly import plotly.js via a <script> tag to get it to work with create-react-app. However, I have found this latter approach (directly using the demo app) does not work any more as you get an compile error: Module not found: Can't resolve 'plotly.js' when trying to run the demo app. However, I am able to get things to work in a more "standard" fashion by npm installing both plotly.js and react-plotly.js and directly importing Plot from react-plotly.js into my React component. From what I had read in some of the issues, it sounded like moving away from the need for customising the web pack config was planned for early 2018, so maybe what I am seeing is a result of that, but wanted to be sure there was not a hidden gotcha somewhere.
Based on this issue Expose Plotly.restyle #25, it sounds like the version I am using should be better about doing updated. However, I have found that updating the state of my component (which changes the data in the Plot component) via a click event when zoomed into a specific region causes the whole plot to unzoom. Am i misunderstanding the scope of this new feature (Expose Plotly.restyle #25) or just making a rookie mistake?
The text was updated successfully, but these errors were encountered: