cleaner callback API #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaner callback API readme tweak
nicolaskruchten
force-pushed
the
figure_in_update
branch
from
449ff3b to
8dbe621
Compare
VeraZab
reviewed
Mar 13, 2018
| <Plot | ||
| data={this.state.data} | ||
| layout={this.state.layout} | ||
| frames={this.state.frames} |
There was a problem hiding this comment.
so here it'd be this.state.figure.frames, this.state.figure.layout, this.state.figure.layout..right
There was a problem hiding this comment.
nope, this.setState(figure) means that the state is the figure. You would be right if I'd done this.setState({figure}) (note the { }).
VeraZab
reviewed
Mar 13, 2018
README.md
Outdated
| | Prop | Type | Default | Description | | ||
| | ------------------ | ---------------------------- | ------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | `data` | `Array` | `[]` | list of trace objects (see https://plot.ly/javascript/reference/) | | ||
| | `layout` | `Object` | `undefined` | layout object (see https://plot.ly/javascript/reference/) | |
There was a problem hiding this comment.
VeraZab
reviewed
Mar 13, 2018
|
|
||
| You can see an example of this method in action | ||
| [here](https://codepen.io/rsreusser/pen/qPgwwJ?editors=1010). | ||
|
|
|
looks good to me! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to partly address #49 and help users avoid issues like #61 or #59