-
Notifications
You must be signed in to change notification settings - Fork 198
Hot reloading tested in different ways and is not working properly #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, if you add your entry to your |
Error will now be thrown in |
@pmmmwh Sorry to write here on a closed issue, but I get a behaviour that is exactly the same @Ridermansb described on his demo.gif I put a sample on this repo FlavioMH/webpackDevServer4HMR
Expected BehaviorBefore to update to webpack v5, I was using webpack v4 with webpack-dev-server v3.11.2. I was also using react-hot-loader and expected behavior was:
Actual BehaviorOnce I save the file, never mind about what change I am doing, browser immediately shows tabl loading spinner and the enite page is refreshed. How can we reproduce the behavior?
Is this an issue with another package? Maybe |
I'll take a look tomorrow. |
@pmmmwh Sorry to bore you...any news on this? |
@FlavioMH This has nothing to do with the plugin. It is probably either something wrong in your Webpack setup, or a bug from WDS. If you just persist the logs from hot reloading (simply by running Which, when I do |
Operating System: macOS Big Sur 11.2
Node Version: v14.15.4
NPM Version: 6.14.10
webpack Version: ^5.19.0
webpack-dev-server Version: ^4.0.0-beta.0
Browser: Google Chrome Version 88
This is a bug
This is a modification request
Code
Repository link: https://github.com/Ridermansb/webpack5Hot
master
branch it's using only basic webpack-dev-server configuration without any pluginsreact-hot-loader
branch it's using react-hot-loader plugin. Pull Request #1react-refresh-webpack-plugin
branch it's using pmmmwh/react-refresh-webpack-plugin webpack plugin. Pull Request #2Expected Behavior
In all case... should not reload the page and only reload the portion that's changed
Actual Behavior
It's Always reloading the entire page.
For Bugs; How can we reproduce the behavior?
Just clone the repository ridermansb/webpack5Hot
npm install
npm start
And try update
Header
componentThe text was updated successfully, but these errors were encountered: