-
Notifications
You must be signed in to change notification settings - Fork 198
feat: use entry hooks for injection in Webpack 5 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pmmmwh , Thanks mike, please bring for us Webpack 5 support, really world of ReactJS developers need this. |
@amerllica |
Hi Michael~ I want to know when to release this PR? I really need it. |
@chang-ke why do you need it? Webpack 5 is already officially supported even without this PR. I'm not planning to finish this PR any time soon. |
Now i'm use dynamic entry, so without this pr, injectEntry doest not work |
Can you explain your use case further with the help of some examples? |
@pmmmwh , What do you mean:
Webpack is a tool for bundling, ReactJS is a library, The Webpack developers haven't made it for specific library. why you said those? |
57895c9
to
3cce460
Compare
TODO:
|
React Refresh is built on top of bundlers' native HMR capabilities. To support a specific bundler (version), we need to have the proper code to hook React Refresh into the HMR lifecycle. Webpack 5 is supported means this plugin will allow you to have React Refresh capabilities if you use Webpack 5 as your bundler. However without this PR there is a small caveat that you cannot rely on Webpack 5's default entry point ( This should make it into the next beta, which will probably be the last one before |
fcfe540
to
9aa580f
Compare
Fixes #293
Fixes #303
Fixes #346
Fixes #398