Make image diffing strategies custom scale aware #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbrandonw @stephencelis do you have an estimate when you will have time to review this PR? Due to this scaling issue the diffs are unusable for us at the moment. |
|
@ffittschen Thanks for this! I merged it into a fork and it worked perfectly. |
stephencelis
approved these changes
Aug 31, 2020
regexident
pushed a commit
to regexident/swift-snapshot-testing
that referenced
this pull request
Sep 18, 2020
* Add scale parameter to image diffing strategies * Use updated diffing in CALayer, UIView, UIViewController and SwiftUIView strategies * Pass scale through to CGPath and UIBezierPath strategies * Re-generate project file
|
Hey @stephencelis, I just noticed this was merged into master, not into main. Should I open a new PR against main or are you going to handle getting this into the right branch? |
YkmLo
added a commit
to YkmLo/swift-snapshot-testing
that referenced
this pull request
Sep 25, 2020
[Update Fork] Make image diffing strategies custom scale aware (pointfreeco#336)
andreyz
added a commit
to andreyz/swift-snapshot-testing
that referenced
this pull request
Dec 18, 2020
…_with_test_plans' into main * origin/master: Make image diffing strategies custom scale aware (pointfreeco#336) * fork1/rtl_support_with_test_plans: Update README Make configuration directory a subdirectory of file name directory Change snapshot directory url when SNAPSHOT_CONFIGURATION_NAME environment variable is available Remove layout direction trait override
dflems
pushed a commit
to dflems/swift-snapshot-testing
that referenced
this pull request
Mar 26, 2021
* Add scale parameter to image diffing strategies * Use updated diffing in CALayer, UIView, UIViewController and SwiftUIView strategies * Pass scale through to CGPath and UIBezierPath strategies * Re-generate project file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue described in #324 and partially in #243.
When overriding the scale of image snapshots by setting the
displayScaleproperty of the passed trait collection, failure diffs were not rendered correctly because the screens scale was used to interpret the snapshot stored on disk.To resolve this issue, I introduced a new scale parameter to the image diffing strategies which falls back to the display scale if it's not set or the default undefined value
0.0of theUITraitCollection.