Remove GLKView support #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenGL types have been marked as deprecated starting with iOS 12, so if
you compile SnapshotTesting with a minimum OS target version of iOS 12
or higher, you get the following compiler warning:
```
SnapshotTesting/Sources/SnapshotTesting/Common/View.swift:585:31: error: 'GLKView' was deprecated in iOS 12.0: OpenGLES API deprecated. (Define GLES_SILENCE_DEPRECATION to silence these warnings)
if let glkView = self as? GLKView {
^
```
Because Swift has no mechanism to silence deprecation warnings, I
propose removing snapshotting support for `GLKView`.
Users of Snapshotting can still maintain support for snapshotting
`GLKView`s with a custom snapshot strategy.
stephencelis
approved these changes
Jan 7, 2022
|
Thanks @stephencelis ! |
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
OpenGL types have been marked as deprecated starting with iOS 12, so if
you compile SnapshotTesting with a minimum OS target version of iOS 12
or higher, you get the following compiler warning:
```
SnapshotTesting/Sources/SnapshotTesting/Common/View.swift:585:31: error: 'GLKView' was deprecated in iOS 12.0: OpenGLES API deprecated. (Define GLES_SILENCE_DEPRECATION to silence these warnings)
if let glkView = self as? GLKView {
^
```
Because Swift has no mechanism to silence deprecation warnings, I
propose removing snapshotting support for `GLKView`.
Users of Snapshotting can still maintain support for snapshotting
`GLKView`s with a custom snapshot strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenGL types have been marked as deprecated starting with iOS 12, so if you compile SnapshotTesting with a minimum OS target version of iOS 12 or higher, you get the following compiler warning:
Because Swift has no mechanism to silence deprecation warnings, I propose removing snapshotting support for
GLKView.Users of Snapshotting can still maintain support for snapshotting
GLKViews with a custom snapshot strategy.