Diff tool arguments support #508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arietis
force-pushed
the
feature/diff_tool_args
branch
from
1671432 to
ef19a7a
Compare
|
@arietis Diff tool arguments can usually be passed before the file names, no? So couldn't you define them in the SnapshotTesting.diffTool = "vimdiff -v" |
|
@stephencelis there might be commands that would want the order of the arguments in tact, e.g. I think for imagemagick you would do the images -> output image for diff at the end, so it would make sense to have the optional arguments. |
|
Closed by #840. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
diffToolArgsvariable which allows slightly better customization of the diff message.