Skip to content

Add support for Windows, add Windows job to ci.yml #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 7, 2022
Merged

Add support for Windows, add Windows job to ci.yml #532

merged 8 commits into from
Jan 7, 2022

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Nov 3, 2021

This adds support for Windows, testing it with both Swift 5.4 and 5.5. I've also expanded macOS testing matrix and cleaned up one for Ubuntu to make them consistent.

@MaxDesiatov MaxDesiatov marked this pull request as ready for review November 3, 2021 22:02
@MaxDesiatov MaxDesiatov changed the title Add Windows job to ci.yml Add support for Windows, add Windows job to ci.yml Nov 3, 2021
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to us!

@stephencelis stephencelis merged commit 3ab2f21 into pointfreeco:main Jan 7, 2022
niil-qb pushed a commit to quickbit/swift-snapshot-testing that referenced this pull request Feb 23, 2023
* Add Windows job to `ci.yml`

* Add missing newline

* Add name field to Windows job, format consistently

* Add `os(Windows)` checks

* Fix Windows tests

* Fix Windows line endings

* Use LF line endings for git checkout on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants