Skip to content

Add SnapshotTestingHEIC to plugins list #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

alexey1312
Copy link
Contributor

No description provided.

Copy link
Contributor

@Sherlouk Sherlouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a good plugin, and glad for it to exist in the community.

README.md Outdated
@@ -223,6 +223,8 @@ end

- [swift-snapshot-testing-stitch](https://github.com/Sherlouk/swift-snapshot-testing-stitch/) adds the ability to stitch multiple UIView's or UIViewController's together in a single test.

- [SnapshotTestingHEIC](https://github.com/alexey1312/SnapshotTestingHEIC) adds HEIC format support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth highlighting the benefits of this? Potentially something like:

Suggested change
- [SnapshotTestingHEIC](https://github.com/alexey1312/SnapshotTestingHEIC) adds HEIC format support.
- [SnapshotTestingHEIC](https://github.com/alexey1312/SnapshotTestingHEIC) adds image support using the HEIC storage format which reduces file sizes in comparison to PNG.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np, I'll fix it 👌

@stephencelis stephencelis merged commit 33dfcad into pointfreeco:main Sep 21, 2022
niil-qb pushed a commit to quickbit/swift-snapshot-testing that referenced this pull request Feb 23, 2023
* Add SnapshotTestingHEIC to plugins list

* Fix README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants