-
Notifications
You must be signed in to change notification settings - Fork 611
Add in diffToolSuffix to support ImageMagick cli #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d1ca9c
to
459cb43
Compare
any idea when this will be merged? |
public var diffTool: String? = nil | ||
public var diffToolSuffix: String = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about rework these two into a reusable, tool-independent message converter?
I'm suggesting this due to the following. Although, the solution offered works fine with these 2 tools, but what about using separate switches to prefix each item (for example: another_img_diff_tool -d 42 -i img1.png -i img2.png
?
Something like this (at the moment I have not bothered to deprecate the old variables, but that would complete the picture):
public var diffMessageConverter: (String, String) → String? = { "\(diffTool) \($0) \($1)" }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion
8959584
Closed by #840. |
Added diffMessageConverter to support other tools like ImageMagick
which has commands that looks like
magick compare "${image1}" "${image2}" diffImage.png