Widen swift-syntax dependency to 508.0.1..<510.0.0 #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making `assertInlineSnapshot` simply unavailable when another dependency locks to 508.0.1. I think there are too many significant changes in swift-syntax 509 to support the function in earlier versions.
|
This is a complete success, thank you very much! This solves #794 completely. :-) I'll wait a little bit more for inline snapshot testing 😉 |
thestephenmarshall
referenced
this pull request
in powerhome/playbook-swift
Oct 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [fastlane](https://fastlane.tools) ([source](https://togithub.com/fastlane/fastlane), [changelog](https://togithub.com/fastlane/fastlane/releases)) | `"~> 2.213.0"` -> `"~> 2.216.0"` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | minor | | [nicklockwood/SwiftFormat](https://togithub.com/nicklockwood/SwiftFormat) | `from: "0.52.6"` -> `from: "0.52.8"` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | patch | | [nicklockwood/SwiftFormat](https://togithub.com/nicklockwood/SwiftFormat) | `0.52.6` -> `0.52.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | repository | patch | | [pointfreeco/swift-snapshot-testing](https://togithub.com/pointfreeco/swift-snapshot-testing) | `from: "1.14.0"` -> `from: "1.14.2"` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | patch | | [pre-commit/pre-commit-hooks](https://togithub.com/pre-commit/pre-commit-hooks) | `v4.4.0` -> `v4.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | repository | minor | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://togithub.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>fastlane/fastlane (fastlane)</summary> ### [`v2.216.0`](https://togithub.com/fastlane/fastlane/releases/tag/2.216.0): Fix for match GitLab storage [Compare Source](https://togithub.com/fastlane/fastlane/compare/2.215.1...2.216.0) - \[match] fixes missing job-token error in GitLab storage mode ([#​21520](https://togithub.com/fastlane/fastlane/issues/21520)) via Darby Frey ([@​darbyfrey](https://togithub.com/darbyfrey)) ### [`v2.215.1`](https://togithub.com/fastlane/fastlane/releases/tag/2.215.1): Workaround for Google Play API instability [Compare Source](https://togithub.com/fastlane/fastlane/compare/2.215.0...2.215.1) - \[supply] add new SUPPLY_UPLOAD_MAX_RETRIES env var to attempt to solve failed Google API calls ([#​21518](https://togithub.com/fastlane/fastlane/issues/21518)) via Josh Holtz ([@​joshdholtz](https://togithub.com/joshdholtz)) ### [`v2.215.0`](https://togithub.com/fastlane/fastlane/releases/tag/2.215.0): Improvements [Compare Source](https://togithub.com/fastlane/fastlane/compare/2.214.0...2.215.0) - \[spaceship] add request retry with backoff when encountring 429 errors ([#​21511](https://togithub.com/fastlane/fastlane/issues/21511)) via Stefan Natchev ([@​snatchev](https://togithub.com/snatchev)) - \[supply] introduce a new synchronization logic for screenshots ([#​21498](https://togithub.com/fastlane/fastlane/issues/21498)) via Olivier Halligon ([@​AliSoftware](https://togithub.com/AliSoftware)) - \[deliver] validate the status of app version to be ready_for_review before submitting the app ([#​20515](https://togithub.com/fastlane/fastlane/issues/20515)) via 醉 ([@​404pilot](https://togithub.com/404pilot)) - \[match] Added s3\_skip_encryption parameter ([#​21018](https://togithub.com/fastlane/fastlane/issues/21018)) via Morten Bøgh ([@​mbogh](https://togithub.com/mbogh)) - \[docs] add minor branding guidelines to `CONTRIBUTING.md` ([#​21495](https://togithub.com/fastlane/fastlane/issues/21495)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) - \[match] prevent directory download from s3 ([#​20975](https://togithub.com/fastlane/fastlane/issues/20975)) via Mark Homoki ([@​markhomoki](https://togithub.com/markhomoki)) - \[xcodes] fix issue where `xcodes` action wouldn't accept beta versions of Xcode ([#​21434](https://togithub.com/fastlane/fastlane/issues/21434)) via apps4everyone ([@​apps4everyone](https://togithub.com/apps4everyone)) - \[spaceship] explicit beta group access to all builds at creation ([#​21478](https://togithub.com/fastlane/fastlane/issues/21478)) via Vincent Isambart ([@​vincentisambart](https://togithub.com/vincentisambart)) - \[docs] update pull request template to ask contributors to write unit tests ([#​21427](https://togithub.com/fastlane/fastlane/issues/21427)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) - \[action] deprecate the ensure_xcode_version action ([#​21448](https://togithub.com/fastlane/fastlane/issues/21448)) via Iulian Onofrei ([@​revolter](https://togithub.com/revolter)) - \[tests] stop generating rspec temp file in current directory ([#​21466](https://togithub.com/fastlane/fastlane/issues/21466)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) - \[ci] fix CI by replacing deprecated Xcode versions, and add Xcode 14, Xcode 15, and Ruby 3.1 to test envs ([#​21465](https://togithub.com/fastlane/fastlane/issues/21465)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) - \[deliver]\[frameit] add iPhone 14 Pro / 6.1" display type ([#​21393](https://togithub.com/fastlane/fastlane/issues/21393)) via Stefan Natchev ([@​snatchev](https://togithub.com/snatchev)) - \[spaceship] add missing `AppStoreState` cases ([#​21312](https://togithub.com/fastlane/fastlane/issues/21312)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) - \[fastlane_core] fix WWDR certificates import flow ([#​21442](https://togithub.com/fastlane/fastlane/issues/21442)) via Paul Taykalo ([@​PaulTaykalo](https://togithub.com/PaulTaykalo)) - \[docs] fix tool name formatting (for `supply`) to be lowercase to pass fastlane docs unit tests ([#​21426](https://togithub.com/fastlane/fastlane/issues/21426)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) ### [`v2.214.0`](https://togithub.com/fastlane/fastlane/releases/tag/2.214.0): Improvements [Compare Source](https://togithub.com/fastlane/fastlane/compare/2.213.0...2.214.0) - \[spaceship] fix olympus session request error after skipping 2FA Upgrade ([#​21317](https://togithub.com/fastlane/fastlane/issues/21317)) via AbbyM ([@​AbbyM](https://togithub.com/AbbyM)) - \[spaceship] add update method to ConnectAPI::User ([#​20956](https://togithub.com/fastlane/fastlane/issues/20956)) via Vitalii Budnik ([@​nekrich](https://togithub.com/nekrich)) - \[supply]\[action] add `download_apk_from_google_play` action (and corresponding `supply` methods) ([#​21315](https://togithub.com/fastlane/fastlane/issues/21315)) via Olivier Halligon ([@​AliSoftware](https://togithub.com/AliSoftware)) - \[docs] fix sync_code_signing.md ([#​21202](https://togithub.com/fastlane/fastlane/issues/21202)) via Yuki Sakai ([@​VeyronSakai](https://togithub.com/VeyronSakai)) - \[fastlane] fix fastlane action template warnings reported by Rubocop ([#​21310](https://togithub.com/fastlane/fastlane/issues/21310)) via Bartosz Kosiorek ([@​BartoszKosiorek-TomTom](https://togithub.com/BartoszKosiorek-TomTom)) - \[docs]\[match] fix typos, improve wording, incorporate improvements to match documentation examples ([#​21302](https://togithub.com/fastlane/fastlane/issues/21302)) via Roger Oba ([@​rogerluan](https://togithub.com/rogerluan)) - \[match] fixes Gitlab Secure Files API limit ([#​21361](https://togithub.com/fastlane/fastlane/issues/21361)) via Darby Frey ([@​darbyfrey](https://togithub.com/darbyfrey)) - \[match] adding access token prompt for GitLab Secure Files Match ([#​21279](https://togithub.com/fastlane/fastlane/issues/21279)) via Darby Frey ([@​darbyfrey](https://togithub.com/darbyfrey)) - \[deliver] update upload_price_tier ([#​21282](https://togithub.com/fastlane/fastlane/issues/21282)) via lukethoene ([@​lukethoene](https://togithub.com/lukethoene)) </details> <details> <summary>nicklockwood/SwiftFormat (nicklockwood/SwiftFormat)</summary> ### [`v0.52.8`](https://togithub.com/nicklockwood/SwiftFormat/blob/HEAD/CHANGELOG.md#0528-2023-10-17) [Compare Source](https://togithub.com/nicklockwood/SwiftFormat/compare/0.52.7...0.52.8) - Fixed `redundantClosure` rule in cases where an `if`/`switch` expression is not permitted - The `docComments` rule now correctly handles macro comments - The `docComments` rule is now only applied to a comment block if all lines match the pattern ### [`v0.52.7`](https://togithub.com/nicklockwood/SwiftFormat/blob/HEAD/CHANGELOG.md#0527-2023-10-06) [Compare Source](https://togithub.com/nicklockwood/SwiftFormat/compare/0.52.6...0.52.7) - Fixed bug where `conditionalAssignment` and `redundantClosure` rules would be applied incorrectly - Fixed `redundantClosure` rule leaving stray `try` or `await` keywords behind </details> <details> <summary>pointfreeco/swift-snapshot-testing (pointfreeco/swift-snapshot-testing)</summary> ### [`v1.14.2`](https://togithub.com/pointfreeco/swift-snapshot-testing/releases/tag/1.14.2) [Compare Source](https://togithub.com/pointfreeco/swift-snapshot-testing/compare/1.14.1...1.14.2) #### What's Changed - Fixed: Inline snapshots are now prepared *before* emitting an XCTest failure, ensuring the artifact is written ([https://github.com/pointfreeco/swift-snapshot-testing/pull/787](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/787)). - Fixed: `assertCustomInline()` no longer leaves empty parens hanging around when expanded ([https://github.com/pointfreeco/swift-snapshot-testing/pull/788](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/788)). - Fixed: The `swift-syntax` dependency has widened to support 508.0.1..<510.0.0, allowing the library to be depended on even when another package depends on 508.0.1 ([https://github.com/pointfreeco/swift-snapshot-testing/pull/795](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/795)). - Infrastructure: Updated SPI configuration for watchOS (thanks [@​finestructure](https://togithub.com/finestructure), [https://github.com/pointfreeco/swift-snapshot-testing/pull/789](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/789)). **Full Changelog**: pointfreeco/swift-snapshot-testing@1.14.1...1.14.2 ### [`v1.14.1`](https://togithub.com/pointfreeco/swift-snapshot-testing/releases/tag/1.14.1) [Compare Source](https://togithub.com/pointfreeco/swift-snapshot-testing/compare/1.14.0...1.14.1) #### What's Changed - Fixed: Avoid inline snapshot trailing closure index crash ([https://github.com/pointfreeco/swift-snapshot-testing/pull/786](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/786)). - Infrastructure: Update .spi.yml to show watchOS support (thanks [@​finestructure](https://togithub.com/finestructure), [https://github.com/pointfreeco/swift-snapshot-testing/pull/785](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/785)). **Full Changelog**: pointfreeco/swift-snapshot-testing@1.14.0...1.14.1 </details> <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v4.5.0`](https://togithub.com/pre-commit/pre-commit-hooks/compare/v4.4.0...v4.5.0) [Compare Source](https://togithub.com/pre-commit/pre-commit-hooks/compare/v4.4.0...v4.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/PlaybookSwift). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Stephen Marshall <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion from #794, we can be a better citizen in the ecosystem and play nicely with those that have stricter dependencies.
I've made
assertInlineSnapshotsimply unavailable when another dependency locks to 508.0.1. I think there are too many significant changes in swift-syntax 509 to support the function in earlier versions.