Configure isRecording default value with launch argument
#862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrapperon
changed the title
isRecording default value with launch argumentsisRecording default value with launch argument
stephencelis
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Thanks! Going to merge as is but will rework in a follow-up PR to use an environment variable instead. Slightly easier to configure for test targets and we think the KEY=VALUE syntax is a bit friendlier than Apple's convention, and more common in the open source community.
awaltzforvenus
pushed a commit
to oreillymedia/native-ios-swift-snapshot-testing
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often want to reset all the snapshots during development of foundational/utility domains that may invalidate many snapshots in many files, and it is currently inconvenient to search and flip flags for these tests.
This PR exposes a launch argument that allows to seed the default of
isRecordingby passing-co.pointfree.SnapshotTesting.IsRecording 1. It is very convenient to have a dedicated scheme (or to use the checkbox) to regenerate all snapshots in a project. This only sets the default value, so it shouldn't affect localisRecordingoverrides.The naming is inspired from the various arguments Apple provides for CoreData, like
-com.apple.CoreData.SQLDebug 1(See here, "Debugging Fetching"). It can of course be discussed.This is fairly additional. Some users have reported more or less involved workarounds (like using subclasses of XCTestCase, or CI scripts), but this solution would make this problem much easier to solve IMO.