enhancement: added commitfest stats to /me page #52
Conversation
pgcommitfest/commitfest/views.py
Outdated
| {"id": cf.id, "user_id": request.user.id}, | ||
| ) | ||
| statussummary = curs.fetchall() | ||
| print(statussummary) |
There was a problem hiding this comment.
test print that should go away
| <p> | ||
| <br/> | ||
| <b>Status summary: </b>{%for id,title,num in statussummary%}<a href="?status={{id}}">{{title}}</a>: {{num}}. {%endfor%} | ||
| </p> |
There was a problem hiding this comment.
Let's move this below the buttons, so it matches the layout of the commitfest page.
pgcommitfest/commitfest/views.py
Outdated
| INNER JOIN commitfest_patchstatus ps ON ps.status=poc.status | ||
| LEFT JOIN commitfest_patch_authors pa ON pa.patch_id=poc.patch_id | ||
| LEFT JOIN commitfest_patch_reviewers pr ON pr.patch_id=poc.patch_id | ||
| LEFT JOIN commitfest_patch_subscribers psubs ON psubs.patch_id=poc.patch_id |
There was a problem hiding this comment.
I'd keep out the subscribers for now, I think it's a good addition, but we don't use that in the display query so that's just confusing.
There was a problem hiding this comment.
Cool, removing this
pgcommitfest/commitfest/views.py
Outdated
| LEFT JOIN commitfest_patch_authors pa ON pa.patch_id=poc.patch_id | ||
| LEFT JOIN commitfest_patch_reviewers pr ON pr.patch_id=poc.patch_id |
There was a problem hiding this comment.
This will inflate counts if a patch has more than one author or reviewer. Instead of doing this join we should use the same WHERE filter we use for the display list:
EXISTS (
SELECT 1 FROM commitfest_patch_reviewers cpr WHERE cpr.patch_id=p.id AND cpr.user_id=%(self)s
) OR EXISTS (
SELECT 1 FROM commitfest_patch_authors cpa WHERE cpa.patch_id=p.id AND cpa.user_id=%(self)s
) OR p.committer_id=%(self)s""")
pgcommitfest/commitfest/views.py
Outdated
| AND ( | ||
| pa.user_id=%(user_id)s | ||
| OR pr.user_id=%(user_id)s | ||
| OR psubs.user_id=%(user_id)s |
There was a problem hiding this comment.
A check for the patch status should be added. Right now it's also showing closed patches, even though we filter these out when displaying the list.
There was a problem hiding this comment.
Adding a check to eliminate committed, withdrawn and rejected patches.
Although wouldn't it be better to also show the withdrawn patches? Just in case if someone wants to revisit the patch in future
pgcommitfest/commitfest/views.py
Outdated
| LEFT JOIN commitfest_patch_authors pa ON pa.patch_id=poc.patch_id | ||
| LEFT JOIN commitfest_patch_reviewers pr ON pr.patch_id=poc.patch_id | ||
| LEFT JOIN commitfest_patch_subscribers psubs ON psubs.patch_id=poc.patch_id | ||
| WHERE commitfest_id=%(id)s |
There was a problem hiding this comment.
This check should be removed, right now we don't filter the list by commitfest_id. So the counts shouldn't be filtered by it either.
Co-authored-by: Jelte Fennema-Nio <[email protected]>
Co-authored-by: Jelte Fennema-Nio <[email protected]>
done |
|
It seems you didn't actually test the changes after applying them, because the page was broken. I fixed those issues and merged the result. |
Oops😅 Yeah really sorry for the incovinience |
Added stats generally visible on the generic commitfest page to the personal dashboard.