Skip to content

Code cleanup and tests stability #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Code cleanup and tests stability #7

merged 3 commits into from
Apr 16, 2021

Conversation

ololobus
Copy link
Contributor

No description provided.

Code cleanup after merge of PGPRO-3253.
Also make free port choosing routine work on BSD-like systems (e.g.
macOS).
@ololobus ololobus requested a review from arssher April 15, 2021 11:07
Cluster.pm Outdated
@@ -32,7 +32,7 @@ sub mm_get_free_port
{

# advance $port, wrapping correctly around range end
$port = 26000 if ++$port == 27000;
$port = 26000 if ++$port >= 27000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== was actually intentional here, allowing run.pl to force its fixed 65432+ range

@arssher
Copy link
Contributor

arssher commented Apr 16, 2021

For the record, this is from PGPRO-4965.

@arssher arssher merged commit 029970c into master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants