Skip to content

Store GUC variables in local process memory to avoid IPC shenanigans #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Medvecrab
Copy link
Contributor

For more context and reasoning see issue #85

@mbanck-cd
Copy link

I have built Postgresql 17 pg_wait_sampling packages with this PR and tested it successfully (albeit not very thoroughly).

The usage of postmaster/interrupt.h means pg_wait_sampling will no longer compile on v12 (at least I got a build failure when I tried), but that one is EOL, so I guess it is ok?

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -g -O2 -ffile-prefix-map=/build/pg-wait-sampling-3SEHBq/pg-wait-sampling-1.1.6=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I. -I./ -I/usr/include/postgresql/12/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o collector.o collector.c
collector.c:19:10: fatal error: postmaster/interrupt.h: No such file or directory
   19 | #include "postmaster/interrupt.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [<builtin>: collector.o] Error 1

@Medvecrab
Copy link
Contributor Author

Yeah, I've seen CI fails, but since PostgreSQL 12 is no longer supported, I don't think we should worry too much. We dropped support for PostgreSQL 11 and older some time ago, so I think we will drop pg12 support some time later as well.

@Medvecrab Medvecrab requested a review from shinderuk January 29, 2025 10:22
@mbanck-cd
Copy link

Yeah, I've seen CI fails, but since PostgreSQL 12 is no longer supported, I don't think we should worry too much. We dropped support for PostgreSQL 11 and older some time ago, so I think we will drop pg12 support some time later as well.

Right, in that case, README.md should be adjusted for s/12/13/ as minimum version, either in this PR or in a follow-up commit.

@Medvecrab Medvecrab force-pushed the local_gucs branch 2 times, most recently from 94ec1f7 to 7c6da04 Compare February 4, 2025 12:29
For more context and reasoning see issue #85
@Medvecrab
Copy link
Contributor Author

I've rebased this branch onto actual master, fixed all review comments

@shinderuk shinderuk merged commit 8f6f7e6 into master Feb 4, 2025
2 checks passed
@shinderuk shinderuk deleted the local_gucs branch February 4, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants