Skip to content

strans is broken #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vitcpp opened this issue Jun 23, 2023 · 4 comments
Closed

strans is broken #17

vitcpp opened this issue Jun 23, 2023 · 4 comments

Comments

@vitcpp
Copy link
Contributor

vitcpp commented Jun 23, 2023

There is an issue with strans that was reported in another repo. Check and fix it in our repo.

akorotkov/pgsphere#11
@esabol
Copy link
Contributor

esabol commented Jun 29, 2023 •
edited
Loading

Could be related to this precision issue?

akorotkov/pgsphere#13

I see a lot of floats in the code. Would changing everything to double precision be a good idea?

@vitcpp
Copy link
Contributor Author

vitcpp commented Jun 30, 2023

I think double precision should be ok. I haven't looked at this problem yet. I think it may be related to the custom epsilon that is choosen as 1E-9 in pgsphere (pg_sphere.h:48). May be it is the source of the problem. May be we should make EPSILON smaller.

vitcpp added a commit that referenced this issue Jul 24, 2023
@vitcpp
Merge pull request #32 from stepan-neretin7/17_fix_theta_function
612f06b 
[ISSUE #17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.
@dura0ok
Copy link

dura0ok commented Jul 24, 2023

Issue can be closed, probably, @vitcpp

@vitcpp
Copy link
Contributor Author

vitcpp commented Jul 24, 2023

@stepan-neretin7 Thank you for your contribution. Closing the issue.

@vitcpp vitcpp closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vitcpp @esabol @dura0ok