Skip to content

Make healpix+smoc compilation optional #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vitcpp opened this issue Jun 23, 2023 · 8 comments
Closed

Make healpix+smoc compilation optional #19

vitcpp opened this issue Jun 23, 2023 · 8 comments
Assignees

Comments

@vitcpp
Copy link
Contributor

vitcpp commented Jun 23, 2023

No description provided.

@esabol
Copy link
Contributor

esabol commented Jun 29, 2023

Yeah, I could really use this, I think. Our main database server is still RHEL 6.x, and I don't think there's a libhealpix for it. I'm not seeing a package for it at least.

I'm getting compilation errors when trying to compile the current master branch of this repo:

g++ -Wall -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -fPIC -DPGSPHERE_VERSION=1.2.1 -I. -I./ -I/local/postgres/install/15.3/include/server -I/lo
cal/postgres/install/15.3/include/internal  -D_GNU_SOURCE    -c -o src/process_moc.o src/process_moc.cpp
src/process_moc.cpp:17:26: error: healpix_base.h: No such file or directory
src/process_moc.cpp: In function 'size_t get_moc_debug(const char**, void (*)(const char*, int))':
src/process_moc.cpp:69: error: expected type-specifier before 'PlanckError'
src/process_moc.cpp:69: error: expected ')' before '&' token
src/process_moc.cpp:69: error: expected '{' before '&' token
src/process_moc.cpp:69: error: 'e' was not declared in this scope
src/process_moc.cpp:69: error: expected ';' before ')' token
src/process_moc.cpp:69: error: expected primary-expression before 'catch'
src/process_moc.cpp:69: error: expected ';' before 'catch'
src/process_moc.cpp: In function 'void moc_debug_log(void (*)(const char*, int), const char*, ...)':
src/process_moc.cpp:84: error: expected type-specifier before 'PlanckError'
src/process_moc.cpp:84: error: expected ')' before '&' token
src/process_moc.cpp:84: error: expected '{' before '&' token
src/process_moc.cpp:84: error: 'e' was not declared in this scope
src/process_moc.cpp:84: error: expected ';' before ')' token
src/process_moc.cpp:84: error: expected primary-expression before 'catch'

etc.

Any short-term workarounds that I can employ?

@esabol
Copy link
Contributor

esabol commented Jun 29, 2023

Any short-term workarounds that I can employ?

I hacked away at the Makefile using #13 as a guideline and managed to get it to compile, install, and crushtest OK. Whew!

@vitcpp
Copy link
Contributor Author

vitcpp commented Jun 30, 2023

@esabol I did that PR but I had a talk with our colleagues from ivoa (I guess). They wanted to make some changes in Makefile till the end of June. I've postponed my changes to avoid conflicts. I will ask them again at the beginning of next week and proceed with it.

@esabol
Copy link
Contributor

esabol commented Jun 30, 2023

Oh, I was going to submit a PR for this, but I'll defer to yours.

@vitcpp
Copy link
Contributor Author

vitcpp commented Jul 3, 2023

Dear @msdemlei, @df7cb. We spoke about some cleanup in Makefile. It was told that there are some changes are planning from your side in Makefile stuff (#8 (comment)). It least I've understood so. How is your progress going? I would like to continue with optional healpix but I'm still waiting some changes from your side to avoid potential conflicts.

I would also propose to create a new Issue for Makefile cleanup task to be able to discuss some changes.

@df7cb
Copy link
Contributor

df7cb commented Jul 4, 2023

Hi, we aren't ready with that yet, so please just go ahead with your changes and we'll cope afterwards. Thanks!

@vitcpp
Copy link
Contributor Author

vitcpp commented Jul 4, 2023

@esabol If you are already have a prepared patch, please, create a PR (may be after PARALLEL SAFE). Otherwise, I will plan to do it. Thank you!

vitcpp added a commit that referenced this issue Jul 11, 2023
@vitcpp
Copy link
Contributor Author

vitcpp commented Jul 11, 2023

The issue is done. @esabol Thank you very much!

@vitcpp vitcpp closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants