Skip to content

g_spoint3_fetch wasn't "too experimental" before 1.1.5 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
df7cb opened this issue Oct 16, 2023 · 1 comment · Fixed by #83
Closed

g_spoint3_fetch wasn't "too experimental" before 1.1.5 #82

df7cb opened this issue Oct 16, 2023 · 1 comment · Fixed by #83

Comments

@df7cb
Copy link
Contributor

df7cb commented Oct 16, 2023

As just mentioned in #75, there is a problem with the spoint3 change from #74:

In version 1.0, the opclass already contained the function g_spoint3_fetch that #74 is adding to 1.3.2.
The function was declared "too experimental and preliminary" in bdc37d1 which is a mega-commit that labelled "pgsphere_1.1.4.916", so later installs don't contain it, but older installations upgraded since then will already have it.

Do we care? The fix would likely be wrapping the "alter operator family" call in upgrade_scripts/pg_sphere--1.3.1--1.3.2.sql.in into a DO block that would ignore the error when the function is already present.

@df7cb
Copy link
Contributor Author

df7cb commented Oct 16, 2023

(I did test upgrading when submitting #74, but had picked 1.1.5 as a starting point...)

df7cb added a commit to cybertec-postgresql/pgsphere that referenced this issue Oct 16, 2023
…ions

Allow upgrading of older installations (made pre 1.1.5) that already
have g_spoint3_fetch in the spoint3 opclass.

Close postgrespro#82.
df7cb added a commit to cybertec-postgresql/pgsphere that referenced this issue Oct 18, 2023
…ions

Allow upgrading of older installations (made pre 1.1.5) that already
have g_spoint3_fetch in the spoint3 opclass.

Close postgrespro#82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant