Source files are moved into src subdirectory. #14
Conversation
|
It seems some checks are failed. I will recheck it. |
vitcpp
force-pushed
the
create-src-subdir
branch
from
6302199 to
1793e40
Compare
|
I've replaced angled braces with quotes in #include statement. It fixes the compilation with clang. Now tests are passed for versions 10+. Now everything should be ok. |
Makefile
Outdated
| OBJS = src/sscan.o src/sparse.o src/sbuffer.o src/vector3d.o src/point.o \ | ||
| src/euler.o src/circle.o src/line.o src/ellipse.o src/polygon.o \ | ||
| src/path.o src/box.o src/output.o src/gq_cache.o src/gist.o src/key.o \ | ||
| src/gnomo.o src/healpix.o src/moc.o src/process_moc.o healpix_bare/healpix_bare.o \ |
There was a problem hiding this comment.
I would wrap this line, but that's a minor nit.
There was a problem hiding this comment.
@esabol thank you for the review. I've added one more commit with wrapping some lines. I've also aligned identation of some lines.
There was a problem hiding this comment.
Well, the indentation of lines 8 and 9 look different from the indentation of lines 10 and 11 now. Are you using a different number of tabs on these lines to indent?
There was a problem hiding this comment.
@esabol I use postgresql code formatting conventions where tab width is 4 and identation is applied using tabs (https://www.postgresql.org/docs/current/source-format.html). It seems spaces are used for identation of untouched lines but I used tabs for identation. It is why there was the difference. I'm going to replace some spaces with tabs. The result will be like this:
But I will look ugly if to set 8 spaces in tab. I propose to follow postgresql conventions and to use tabs with width 4 for identation. What do you think?
There was a problem hiding this comment.
@esabol Finally, I've decided to wrap the long line and nothing more. All my previous explanations seems to be wrong because postgresql coding standards are related to source files. Sorry. I propose to reformat Makefile in a separate PR later because there are different formatting styles used inside - the mix of spaces and tabs.
There was a problem hiding this comment.
What do you think?
My comment was just that lines 8-11 should be consistent in how they are indented.
I think tabs are expected to be 8 spaces wide in Makefiles, but I'm not 100% sure.
Continuation lines like this should be indented with at least one tab.
There was a problem hiding this comment.
@esabol I think I've done what you proposed. Now indentation is consistent for these lines. I apologize I have made some noise here. We can go further If everything is ok now. Thank you!
There was a problem hiding this comment.
It looks perfect to me, @vitcpp ! Thank you!
vitcpp
force-pushed
the
create-src-subdir
branch
from
578f98e to
f92829b
Compare
vitcpp
force-pushed
the
create-src-subdir
branch
from
f92829b to
9b1153c
Compare
|
Dear All, thank you! I will merge it tomorrow if no objections appear. |
Source files were moved into the src subdirectory in order to avoid file mess in the project root directory.