[ISSUE-10] Implemented propagation of pg sphere version. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there are build problems on 11+ versions. The error is occured when compiling with clang. It seems PG_CFLAGS is not used with clang. Not sure, how clang compilation is performed. I see no clang rules. It is interesting that there is no clang compilation with 10 version. Investigating it. |
vitcpp
force-pushed
the
10-pgsphere-version
branch
from
f38b142 to
894f9bb
Compare
|
The problem with clang was because of JIT compilation (--with-llwm option). Variables PG_CXXFLAGS, PG_CFLAGS are not propagated into clang compilation. Using PG_CPPFLAGS fixes the problem. |
esabol
approved these changes
Jun 27, 2023
|
@esabol thank you for the review. I'm going to merge this PR because there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented propagation of pg sphere version from Makefile into the code. Fixed pg_sphere_version function.