Skip to content

[ISSUE #42] Fix compiler warning #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

[ISSUE #42] Fix compiler warning #47

merged 1 commit into from
Aug 5, 2023

Conversation

dura0ok
Copy link

@dura0ok dura0ok commented Aug 4, 2023

No description provided.

@dura0ok dura0ok force-pushed the fix-compiler-warnings branch from 18f7b6e to cbf89a8 Compare August 4, 2023 22:07
esabol
esabol approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@esabol esabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you, @stepan-neretin7 !

vitcpp
vitcpp approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@vitcpp vitcpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm ok with the fix. One trivial concern is the chosen variable name, but I do not see the sense in asking authors about it. It may be easily changed in the future.

@vitcpp vitcpp merged commit 04456c7 into postgrespro:master Aug 5, 2023
@esabol esabol mentioned this pull request Aug 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitcpp vitcpp vitcpp approved these changes

@esabol esabol esabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dura0ok @vitcpp @esabol