Add MOC vs. other geometries casts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in contains and intersects constraints. I'm also adding a little file on how to hack pg_sphere; yes, that's mainly repeating stuff from the pg docs, but I guess it'll help a few folks; it would have helped me.
I hadn't done this before because the warnings spoiled the regression expectation. I'm now shutting those up for while I'm doing the dropping.
|
Can I bump this? The CI failures, I think, are unrelated to the PR, as pgsphere probably doesn't work with 9.x anyway (or does it? And if so, is there a strong case to not drop 9.x support?). I give you this isn't perfect and rather certainly won't be terribly fast, but then it will help for tables in the ~1e4 rows range, such as rr.stc_spatial in future RegTAP (the VO registry discovery protocol, https://github.com/ivoa-std/RegTAP). |
|
Since it'd be great to have these operators for RegTAP 1.2, https://ivoa.net/documents/RegTAP/20220519/, can I nag again about this? I realise we'll not win beauty contests with this, but I'd say it's reasonably harmless and cheap while giving a rather real benefit... |
gmantele
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable search conditions such as scircle <@ moc. It is implemented as syntactic sugar, turning this, in effect, into smoc(max_order(moc), scircle) <@ moc.
While this has several drawbacks against a strict implementation of contains and overlap between spherical geometries and mocs – most notably, it will be a lot slower when comparing a constant geometry against moc-valued columns, because the conversion will be re-done in every row –, implementing these exact operations is at least hard.
For casual users, I argue, this will provide non-surprising behaviour.
This PR also bumps the version to 1.2.1. Piggyback on it rides a brief hacking guide I came up with while writing this.