test rum failed with PostgreSQL 9.6 beta4

[digoal]

HI,
When i use make installcheck test rum, there is one failed.

make USE_PGXS=1  installcheck
/home/digoal/pgsql9.6/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --bindir='/home/digoal/pgsql9.6/bin'    --dbname=contrib_regression rum ruminv timestamp orderby altorder
(using postmaster on /data04/digoal/pg_root1926, port 1926)
============== dropping database "contrib_regression" ==============
DROP DATABASE
============== creating database "contrib_regression" ==============
CREATE DATABASE
ALTER DATABASE
============== running regression test queries        ==============
test rum                      ... FAILED
test ruminv                   ... ok
test timestamp                ... ok
test orderby                  ... ok
test altorder                 ... ok

======================
 1 of 5 tests failed. 
======================

The differences that caused some tests to fail can be viewed in the
file "/home/digoal/rum/regression.diffs".  A copy of the test summary that you see
above is saved in the file "/home/digoal/rum/regression.out".

make: *** [installcheck] Error 1

diff:

cat /home/digoal/rum/regression.diffs
*** /home/digoal/rum/expected/rum.out   2016-08-20 20:17:37.685721686 +0800
--- /home/digoal/rum/results/rum.out    2016-08-20 20:20:45.365726520 +0800
***************
*** 123,141 ****
   rum_ts_distance |                                    t                                     |                               a                               
  -----------------+--------------------------------------------------------------------------+---------------------------------------------------------------
           16.4493 | my appreciation of you in a more complimentary way than by sending this  | 'appreci':2 'complimentari':8 'send':12 'way':9
!          16.4493 | itself. Put on your “specs” and look at the castle, half way up the      | 'castl':10 'half':11 'look':7 'put':2 'spec':5 'way':12
           16.4493 | so well that only a fragment, as it were, gave way. It still hangs as if | 'fragment':6 'gave':10 'hang':14 'still':13 'way':11 'well':2
!          16.4493 | thinking--“to go or not to go?” We are this far on the way. Reached      | 'far':11 'go':3,7 'reach':15 'think':1 'way':14
  (4 rows)

  SELECT rum_ts_distance(a, to_tsquery('pg_catalog.english', 'way & (go | half)')), *
        FROM test_rum
        WHERE a @@ to_tsquery('pg_catalog.english', 'way & (go | half)')
        ORDER BY a <=> to_tsquery('pg_catalog.english', 'way & (go | half)');
!  rum_ts_distance |                                  t                                  |                            a                            
! -----------------+---------------------------------------------------------------------+---------------------------------------------------------
!          8.22467 | itself. Put on your “specs” and look at the castle, half way up the | 'castl':10 'half':11 'look':7 'put':2 'spec':5 'way':12
!          57.5727 | thinking--“to go or not to go?” We are this far on the way. Reached | 'far':11 'go':3,7 'reach':15 'think':1 'way':14
  (2 rows)

  SELECT
--- 123,141 ----
   rum_ts_distance |                                    t                                     |                               a                               
  -----------------+--------------------------------------------------------------------------+---------------------------------------------------------------
           16.4493 | my appreciation of you in a more complimentary way than by sending this  | 'appreci':2 'complimentari':8 'send':12 'way':9
!          16.4493 | itself. Put on your “specs” and look at the castle, half way up the      | 'castl':10 'half':11 'look':7 'put':2 'way':12 '“specs”':5
           16.4493 | so well that only a fragment, as it were, gave way. It still hangs as if | 'fragment':6 'gave':10 'hang':14 'still':13 'way':11 'well':2
!          16.4493 | thinking--“to go or not to go?” We are this far on the way. Reached      | 'far':12 'go':3,7 'reach':16 'think':1 'way':15 '“to':2 '”':8
  (4 rows)

  SELECT rum_ts_distance(a, to_tsquery('pg_catalog.english', 'way & (go | half)')), *
        FROM test_rum
        WHERE a @@ to_tsquery('pg_catalog.english', 'way & (go | half)')
        ORDER BY a <=> to_tsquery('pg_catalog.english', 'way & (go | half)');
!  rum_ts_distance |                                  t                                  |                               a                               
! -----------------+---------------------------------------------------------------------+---------------------------------------------------------------
!          8.22467 | itself. Put on your “specs” and look at the castle, half way up the | 'castl':10 'half':11 'look':7 'put':2 'way':12 '“specs”':5
!          65.7974 | thinking--“to go or not to go?” We are this far on the way. Reached | 'far':12 'go':3,7 'reach':16 'think':1 'way':15 '“to':2 '”':8
  (2 rows)

  SELECT
***************
*** 144,153 ****
        *
        FROM test_rum
        ORDER BY a <=> to_tsquery('pg_catalog.english', 'way & (go | half)') limit 2;
!  ?column? | rum_ts_distance |                                  t                                  |                            a                            
! ----------+-----------------+---------------------------------------------------------------------+---------------------------------------------------------
!   8.22467 |         8.22467 | itself. Put on your “specs” and look at the castle, half way up the | 'castl':10 'half':11 'look':7 'put':2 'spec':5 'way':12
!   57.5727 |         57.5727 | thinking--“to go or not to go?” We are this far on the way. Reached | 'far':11 'go':3,7 'reach':15 'think':1 'way':14
  (2 rows)

  INSERT INTO test_rum (t) VALUES ('foo bar foo the over foo qq bar');
--- 144,153 ----
        *
        FROM test_rum
        ORDER BY a <=> to_tsquery('pg_catalog.english', 'way & (go | half)') limit 2;
!  ?column? | rum_ts_distance |                                  t                                  |                               a                               
! ----------+-----------------+---------------------------------------------------------------------+---------------------------------------------------------------
!   8.22467 |         8.22467 | itself. Put on your “specs” and look at the castle, half way up the | 'castl':10 'half':11 'look':7 'put':2 'way':12 '“specs”':5
!   65.7974 |         65.7974 | thinking--“to go or not to go?” We are this far on the way. Reached | 'far':12 'go':3,7 'reach':16 'think':1 'way':15 '“to':2 '”':8
  (2 rows)

  INSERT INTO test_rum (t) VALUES ('foo bar foo the over foo qq bar');

======================================================================

[za-arthur]

Hello,
From your diff I see that in your results "specs" was parsed not as expected. Expected result is 'specs' word without quotes. Do you use standard 'pg_catalog.english' dictionary? Do you use your own text search parser?

[za-arthur]

I think it was because of UNICODE quotes. I fixed tests, check please.

[jmscott]

passes under macos sierra. i had consistent failures earlier.

Darwin tmonk.local 16.0.0 Darwin Kernel Version 16.0.0: Mon Aug 29 17:56:20
PDT 2016; root:xnu-3789.1.32~3/RELEASE_X86_64 x86_64

-j

On Sun, Oct 16, 2016 at 2:07 PM, Arthur [email protected] wrote:

I think it was because of UNICODE quotes. I fixed tests, check please.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKCzx-U41HqdWeQql0y1fnQBd1ijmks5q0nXwgaJpZM4JpEIs
.

[za-arthur]

Hello John,

Glad to hear that. I reproduced the issue #2. I reproduced it with locale C (initdb --locale=C). It is my omission that I didn't test with locale C.

[jmscott]

Glad to hear that. I reproduced the issue #2
#2. I reproduced it with locale
C (initdb --locale=C). It is my omission to not test with locale C

hmm. i could of sworn i tested that case when i first saw the issue. oh
well.

-j

On Wed, Oct 19, 2016 at 8:33 AM, Arthur [email protected] wrote:

Closed #7 #7.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKCb0JyJNw09YKMgPRv0mmSS1Cr73ks5q1hwRgaJpZM4JpEIs
.

[za-arthur]

hmm. i could of sworn i tested that case when i first saw the issue. oh
well.

Just for the clarity. As I can understand this issue and the issue #2 don't occur in your environment?

[jmscott]

Just for the clarity. As I can understand this issue and the issue #2
#2 don't occur in your
environment?

my tests for a locale set to C were failing. now locale C passes for
trunk/84f8d3effae
on mac 10.12 and ubunutu 16.04 (4.4 kernel).
earlier the centos 2.6.32 kernel was failing, but i don't have a vm handy
to retest.

-j

On Tue, Oct 25, 2016 at 3:54 PM, Arthur [email protected] wrote:

hmm. i could of sworn i tested that case when i first saw the issue. oh
well.

Just for the clarity. As I can understand this issue and the issue #2
#2 don't occur in your
environment?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKBhXIb7UUdJGT_YFFoOB84nHGHNYks5q3myDgaJpZM4JpEIs
.