Skip to content

Adding eslint in system tests #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
umeshp7 opened this issue Feb 24, 2020 · 2 comments · Fixed by #177
Closed

Adding eslint in system tests #166

umeshp7 opened this issue Feb 24, 2020 · 2 comments · Fixed by #177

Comments

@umeshp7
Copy link
Contributor

umeshp7 commented Feb 24, 2020

All code-generators have their own eslint check but there are no eslint for lib, test, npm and index.js.
Add eslint checks to the root files and folders apart from codegen folder.

@vibhorgupta-gh
Copy link
Contributor

@umeshp7 added linting, however there are a lot errors that cause a process exit. Shall I push a commit fixing them as well?

@shreys7
Copy link
Member

shreys7 commented Feb 26, 2020

@VibhorCodecianGupta this should be mentioned on the pull request and not on the issue page.😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants