-
Notifications
You must be signed in to change notification settings - Fork 360
Add: Eslint in root files/folders #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@umeshp7 added linting, however there are a lot errors that cause a process exit. Shall I push a commit fixing them as well? |
@VibhorCodecianGupta Yes, it would be good to have those fixes as well. |
@umeshp7 fixed lint errors except one, |
@VibhorCodecianGupta you can split the line 44 into two strings, the second one on a new line. For the |
Some tests are failing here: https://travis-ci.com/postmanlabs/postman-code-generators/builds/150958863#L2505 @VibhorCodecianGupta |
The test that is failing is due to a duplicate copy of a dependency |
@VibhorCodecianGupta any updates on this? We'll have to close this soon due to inactivity. |
@shreys7 @umeshp7 so Also, the ENOENT tests are failing because |
@umeshp7 @shreys7 update, rebasing will resolve
This issue still remains though. How to proceed? |
Fixes #166
Check issue comments for description