Move test file creation step from ci-requirements script to test script for form data testing #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreys7
changed the title
|
@shreys7 I have already mentioned in the issue, that I'm working on this and about to submit my PR! |
sastava007
reviewed
Feb 27, 2020
|
@shreys7 Need rebasing with develop for branch tests to pass. |
shreys7
force-pushed
the
bugfix/test-file-formdata-fix
branch
from
c2d1eb0 to
a00537d
Compare
umeshp7
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the files required for testing form data file uploads were created using
ci-requirements.shstep. This file is not run locally and hence would cause form-data tests to fail locally. This step has been removed fromci-requirements.shfile and moved totest.shfile.This fixes #172