Added ES6 feature support to NodeJS-Request codegen #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreys7
requested changes
Feb 28, 2020
|
@shreys7 Have updated as you said, once this one gets accepted for |
|
@umeshp7 Can you please review this? |
umeshp7
reviewed
Mar 2, 2020
umeshp7
reviewed
Mar 2, 2020
|
We'll need an extra set of newman tests, with this option enabled true. We need to make sure the snippet generated is runnable. |
|
@umeshp7 I have added a new block inside the main mocha suite with |
umeshp7
approved these changes
Mar 2, 2020
Closed
shreys7
approved these changes
Mar 2, 2020
|
@sastava007 Merging this, you can start working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It allows the user to generate the code snippet for NodeJS Request in ES6 format.
This is in response to issue #115 requested by one of the users.
Changes I made
Registered a new parameter ES6_enabled in
options()which allows the user to toggle between whether codegen generates snippet with ES6 features or not.By default ES6_enabled is set to
falseAlso added the new created option parameter in
structure.test.jsfile to register it as a valid option id.Added unit tests to verify the generated snippets.
Follow Up
This PR is first in the series of upcoming PRs which will add the feature of generating code snippet in ES6 notation with NodeJS.