Fixed Issue #193

[nikhilmuz]

Refactored global namespase import for shelljs in boilerplate and refactored codegens accordingly as per issue #193

[nikhilmuz]

Fixed global namespace imports for shelljs having potential for conflict with local functions in future and refactored all codegens respectively. Also fixed it for boilerplate in order to avoid this while bootstrapping for new language/framework. @umeshp7 Approval required.

[nikhilmuz]

@shreys7 Review required

[shreys7]

@nikhilmuz I have reviewed the code. Can you just check once if the following commands work perfectly after the changes?

in the root repo:

• npm run test
• npm run test <codegen-name>

cd inside any codegen

• npm run test
• npm run test-unit
• npm run test-lint

[nikhilmuz]

I have done lint test inside every codegen. It passes. I will do remaining tests and will update you.

…

On Wed, 18 Mar, 2020, 12:39 pm Shrey Shah, ***@***.***> wrote: @nikhilmuz <https://github.com/nikhilmuz> I have reviewed the code. Can you just check once if the following commands work perfectly after the changes? in the root repo: - npm run test - npm run test <codegen-name> cd inside any codegen - npm run test - npm run test-unit - npm run test-lint — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEZUYF5NTOEGZE7NMLKWH2DRIBXSXANCNFSM4LAYN7PA> .

[nikhilmuz]

@nikhilmuz I have reviewed the code. Can you just check once if the following commands work perfectly after the changes?

in the root repo:

• npm run test
• npm run test <codegen-name>

cd inside any codegen

• npm run test
• npm run test-unit
• npm run test-lint

@shreys7 I have done lint test on all the codegens locally npm run test-lint and since CI is passing and while going through CI log and test script I checked it runs npm run test recursively on each codegen. Thus, the codegen must be passing. So it seems safe to merge this PR for the changes which is reflected here.
P. S. All the npm test not passing on my local as I have not configured this repo for all languages. Though, I don't guess it is something to be concerned about as it's passing on CI.

[shreys7]

Merging this, thanks for the contribution 😄