-
Notifications
You must be signed in to change notification settings - Fork 360
Converted test.sh bash script to Javascript #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@umeshp7 Please review. |
I tried running it twice, but it failed with the same errors @sastava007 |
@shreys7 Any hint, on what I might be doing wrong? |
@sastava007 You could try removing
|
@sastava007 |
@umeshp7 Okay, I'll try to fix them once I complete the draft for my proposal. |
This might be a problem with shelljs. Checkout this. Try updating to shelljs 0.8.2 or above, currently latest stable release is 0.8.4. @sastava007 |
@someshkoli Yeah, I've figured it out. I will update and submit by weekend. |
Stale |
What this PR does
This PR converts the
test.sh
bash script file to javascript making it the platform agnostic. This PR is part of a series of PRs trying to solve issue #174Changes you made
Converted the bash commands into it's closely equivalent JS commands using
shellJS
package.Screenshot/ CodeSnippet
Not required
Test Configuration:
Tried to test locally for various codegens by running
npm test <codegen-name>
and comparing the result obtained with that generated from the similar bash script.Follow up
Not required
Thanks for contributing! ❤️