Converted package.sh and zip.sh to Javascript files. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@umeshp7 Can you please review? |
umeshp7
suggested changes
Mar 17, 2020
|
@sastava007 Hey, I ran the scripts locally, and firstly I could find many lint errors. Can you please rebase with the recent develop and fix those. (Recent develop will have linting for root files as well) Also, remove Everything else looks good 👍. |
sastava007
force-pushed
the
bash/package-zip
branch
from
5e289d8 to
1ff06dd
Compare
|
@umeshp7 Have fixed everything as you said, please have a look. |
umeshp7
approved these changes
Mar 25, 2020
someshkoli
pushed a commit
to someshkoli/postman-code-generators
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR converts the
package.shandzip.shbash script file to javascript making it the platform agnostic. This PR is last in the series of PRs trying to solve issue #174Changes you made
Converted the bash commands into it's closely equivalent JS commands using
shellJSnpm package.Screenshot/ CodeSnippet
Not required
Test Configuration:
Tried to test locally for various codegens by running
npm package <codegen-name>and comparing the result obtained with that generated from the similar bash script.Follow up
Not required
Thanks for contributing! ❤️