Skip to content

Add optional import of FoundationNetworking in swift codegen to make it work with Swift 5.x #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2020
Merged

Add optional import of FoundationNetworking in swift codegen to make it work with Swift 5.x #354

merged 2 commits into from
Oct 20, 2020

Conversation

webholik
Copy link
Contributor

@webholik webholik commented Oct 9, 2020

Fix #353.

@umeshp7
Copy link
Contributor

umeshp7 commented Oct 10, 2020

Can we test this somehow using the newman test?
What is the current version of swift that we are using in newman test?
@webholik

@webholik
Copy link
Contributor Author

@umeshp7 We are running Swift 5.0.1 for newman tests. The changes happened in Swift 5.1. Perhaps we could change ci-requirements.sh to run Swift 5.1.

@umeshp7
Copy link
Contributor

umeshp7 commented Oct 15, 2020

@webholik yes we can update it to 5.1
Maybe in future we can decide how we can run newman test for multiple versions.

@umeshp7 umeshp7 merged commit 1c77a91 into develop Oct 20, 2020
@umeshp7 umeshp7 deleted the fix/issue-353 branch December 15, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umeshp7 umeshp7 umeshp7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swift codegen needs to import FoundationNetworking to work with Swift 5.x
2 participants
@webholik @umeshp7