Adds additional option to curl codegen #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds quoteType option to getOption function - Adds quoteType option to README in available options - Adds quoteType in example snippet in README - sets the url quote to one provided in options, if not provided default will be used
- adds quoteType option to structure - adds unit test for single quote quoteType - adds unit test for double quote quoteType
…generators into fix/quoteOption pulls ci fixes and nodejs-axios codegen
- Changes quoteType values to single/double instead of '/" - Changes quoteType option values in newman/unit test - fixes typos in curl/README - Changes example in curl/README for new option values - Changes description of quoteType option where necessary
umeshp7
reviewed
Oct 29, 2020
codegens/curl/lib/index.js
Outdated
| availableOptions: ['single', 'double'], | ||
| type: 'string', | ||
| default: 'single', | ||
| description: 'String denoting the quote type to use (single or double) for URL' |
There was a problem hiding this comment.
Do you think we should also specify when single and double quote are preferable like for line continuation (generally, ...) ? @webholik
umeshp7
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new PR for #251.