-
Notifications
You must be signed in to change notification settings - Fork 360
Removed semaphore from swift snippet #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed semaphore from swift snippet #664
Conversation
@@ -250,11 +250,11 @@ self = module.exports = { | |||
description: 'Remove white space and additional lines that may affect the server\'s response' | |||
}, | |||
{ | |||
name: 'Follow redirects', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SahilChoudhary22 any specific reason we removed this option? We might need to block the redirects if its unchecked right? Or you removed as it was not getting used.
cc @VShingala do we not block redirects if this flag is off 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshaydeo Yes, we observed that this option was not getting used in the business logic and therefore it being true
or false
was not making any difference to the output. Also, it was observed that it was not mentioned in the swift test cases (Ref)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshaydeo Swift by default follows redirection and from our research, there was no easy way to control this behavior from swift using some option. So yeah as it's not possible from Swift language itself, the option was not used.
Fixes
pull_request
as GitHub actions workflow triggerfollowRedirect
option from the swift language codegen