Fixed a bug which caused allow_redirects to be listed twice in python requests #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted twice when follow redirect options is set to false
|
VShingala
reviewed
Aug 21, 2019
| @@ -110,7 +110,6 @@ self = module.exports = { | |||
| ', data = payload, files = files' : ', data = payload'; | |||
| snippet += !options.followRedirect ? ', allow_redirects=False' : ''; | |||
There was a problem hiding this comment.
Leave space behind and after = in allow_redirects=False in generated python code. as we are doing the same in other places. i.e data = payload and files = files.
Also update test according to it.
VShingala
reviewed
Aug 21, 2019
| expect.fail(null, null, err); | ||
| } | ||
| expect(snippet).to.be.a('string'); | ||
| expect(snippet).to.not.include('allow_redirects=False, allow_redirects=false'); |
There was a problem hiding this comment.
If options.requestTimeout !== 0 is true than this will be not valid as generated snippet will have allow_redirects=False, timeout=${options.requestTimeout}, allow_redirects=false.
…ween the two allow_redirects
VShingala
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #73