Fix lots of examples warnings #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Alucowie Thanks a lot for your PRs, I will review them in the upcoming weeks. |
Alucowie
force-pushed
the
fix-examples-warnings
branch
from
36232af to
f335834
Compare
|
Hi @AlejandroCosin, I saw you commit a fix on HelloAPI, I removed my MR. |
Loop variable buffFmt creates a copy from type ImageFormat. Prevent copying and silence compiler warning.
This move prevents compiler to trigger unused-variable warnings.
This also avoids "unused-but-set-variable" warnings.
Alucowie
force-pushed
the
fix-examples-warnings
branch
from
f335834 to
6c32edf
Compare
|
Hi @Alucowie, Thanks a lot for your contribution. Your changes are not being ignored: Before approving your PRs I need to integrate the changes in an internal branch (we use the SDK in over a dozen different platforms) and I need to make sure all builds pass, and then do testing to make sure the changes works fine in all the platforms for all SDK samples. |
AlejandroCosin
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes are ordered by modules (OGLES/Vulkan/framework) and warnings class.
Here the list of warnings class fixed : class-memaccess, unsused variable, unused but set variable, unused function, stringop-overread, sign-compare, catch-value, invalid-offsetof, switch, return-value, reorder, unknown-pragmas, range-loop-construct and cast-user-defined.