IgnoreAttribute not working

[blimkemann]

I have a base class that includes [Ignore] on a couple of properties. I am calling CreateTable on a derived class and the ignored properties in the base class are not being ignored.

Example:

public class BaseClass
{
  [Ignore]
  public string ToIgnore
  {
    get;
    set;
  }
}

public class TableClass : BaseClass
{
  public string Name { get; set; }
}

Calling CreateTable<TableClass> creates a table with Name AND ToIgnore!

This is in a NetStandard project.

A fix involves modifying the TableMapping method as follows:

var cols = new List<Column> ();
			foreach (var p in props) {
				var ignore = p.GetCustomAttribute<IgnoreAttribute>(); //p.IsDefined(typeof(IgnoreAttribute),true);
				if (p.CanWrite && ignore==null) { //!ignore) {
					cols.Add (new Column (p, createFlags));
				}
			}

[praeclarum]

Oh thanks for catching that. Have to check the tests to see why this wasn't caught.

I thought p.IsDefined(typeof(IgnoreAttribute),true); was enough...

[praeclarum]

I can't repro the bug -- IsDefined(..., true) works.

Which version of .NET are you running this on?

[blimkemann]

The code I have the database initialization in is NetStandard 1.4 and I was running it via a UWP Xamarin Forms app. From: Frank A. Krueger [mailto:[email protected]] Sent: Friday, July 28, 2017 3:25 PM To: praeclarum/sqlite-net <[email protected]> Cc: Brian Limkemann <[email protected]>; Author <[email protected]> Subject: Re: [praeclarum/sqlite-net] IgnoreAttribute not working (#586) I can't repro the bug -- IsDefined(..., true) works. Which version of .NET are you running this on? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#586 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJ6LVczjGgyT4K5v1m1nynkOQLuFsP1xks5sSjWKgaJpZM4Oj227>.

[hvaughan3]

@praeclarum @blimkemann
Possibly related to my post here?

[blimkemann]

I think it is the same issue. From: Hines Vaughan [mailto:[email protected]] Sent: Monday, July 31, 2017 11:09 PM To: praeclarum/sqlite-net <[email protected]> Cc: Brian Limkemann <[email protected]>; Mention <[email protected]> Subject: Re: [praeclarum/sqlite-net] IgnoreAttribute not working (#586) @praeclarum<https://github.com/praeclarum> @blimkemann<https://github.com/blimkemann> Possibly related to my post here<#549 (comment)>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#586 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJ6LVcHop4T12ZxESfNjUtLyGCIqc6Ljks5sTpbegaJpZM4Oj227>.

[praeclarum]

Here is the test code I wrote: https://github.com/praeclarum/sqlite-net/blob/master/tests/IgnoreTest.cs#L95-L126

		public class BaseClass
		{
			[Ignore]
			public string ToIgnore {
				get;
				set;
			}
		}

		public class TableClass : BaseClass
		{
			public string Name { get; set; }
		}

		[Test]
		public void BaseIgnores ()
		{
			var db = new TestDb ();
			db.CreateTable<TableClass> ();

			var o = new TableClass {
				ToIgnore = "Hello",
				Name = "World",
			};

			db.Insert (o);

			var oo = db.Table<TableClass> ().First ();

			Assert.AreEqual (null, oo.ToIgnore);
			Assert.AreEqual ("World", oo.Name);
		}

The test passes. Is your code different?

[blimkemann]

Have you run this test from a netstandard project that is referenced by UWP? That is my particular environment (haven’t tried other platforms yet) and I’m wondering if it’s a UWP / NetStandard issue? From: Frank A. Krueger [mailto:[email protected]] Sent: Tuesday, August 1, 2017 12:10 PM To: praeclarum/sqlite-net <[email protected]> Cc: Brian Limkemann <[email protected]>; Mention <[email protected]> Subject: Re: [praeclarum/sqlite-net] IgnoreAttribute not working (#586) Here is the test code I wrote: https://github.com/praeclarum/sqlite-net/blob/master/tests/IgnoreTest.cs#L95-L126 public class BaseClass { [Ignore] public string ToIgnore { get; set; } } public class TableClass : BaseClass { public string Name { get; set; } } [Test] public void BaseIgnores () { var db = new TestDb (); db.CreateTable<TableClass> (); var o = new TableClass { ToIgnore = "Hello", Name = "World", }; db.Insert (o); var oo = db.Table<TableClass> ().First (); Assert.AreEqual (null, oo.ToIgnore); Assert.AreEqual ("World", oo.Name); } The test passes. Is your code different? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#586 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJ6LVesLazkyC4f5k5CD4dHCjYdShMPKks5sT03fgaJpZM4Oj227>.

[hvaughan3]

A test case for my specific issue would look like this (though I have not actually tried running the following code myself):

        public class BaseClass
	{
		public List<string> ToIgnore {
			get;
			set;
		}
	}

            //EDIT: Adding new keyword after praeclarum's comment
	public class TableClass : BaseClass
	{
                [Ignore]
		public new List<string> ToIgnore {
			get;
			set;
		}
	}

When it tries to create TableClass table it will ignore the [Ignore] attribute in the derived class.

[praeclarum]

OK, that's a bit different than the test (you would need the new keyword FYI). I'll try that out.