Skip to content

Replacing urllib2 with requests #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2017
Merged

Replacing urllib2 with requests #66

merged 2 commits into from
Nov 23, 2017

Conversation

apb7
Copy link
Contributor

@apb7 apb7 commented Nov 21, 2017

No description provided.

@apb7
Copy link
Contributor Author

apb7 commented Nov 21, 2017

I switched over to Python2 yet there is some problem with travis. Please see to it @prateekiiest .

@prateekiiest
Copy link
Owner

I am working on that.
Merging can be done only after the fix :)

prateekiiest
prateekiiest approved these changes Nov 23, 2017
View reviewed changes
Copy link
Owner

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran your code locally.
Looks good !

@prateekiiest prateekiiest merged commit 8b60da4 into prateekiiest:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekiiest prateekiiest prateekiiest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apb7 @prateekiiest