Skip to content

max_n_samples in add trace(s) seems to do nothing with plotly-resampler=0.8.1 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonasvdd opened this issue Oct 19, 2022 · 1 comment
Closed

max_n_samples in add trace(s) seems to do nothing with plotly-resampler=0.8.1 #124

jonasvdd opened this issue Oct 19, 2022 · 1 comment
Assignees
@jonasvdd
Labels
bug Something isn't working

Comments

@jonasvdd
Copy link
Member

jonasvdd commented Oct 19, 2022 •
edited
Loading

I was able to pinpoint the issue, and it seems that this line within AbstractFigureResampler causes the issue:

super(self._figure_class, self).add_trace(trace, **trace_kwargs)

Which calls the BaseTraceDatatype its add_trace method, which on its end:
image

calls self.add_trace (bringing us back to the AbastractFigureResampler class, and as a result, the trace will be aggregated.
@jonasvdd jonasvdd self-assigned this Oct 19, 2022
@jonasvdd jonasvdd added the bug Something isn't working label Oct 19, 2022
jonasvdd added a commit that referenced this issue Oct 21, 2022
@jonasvdd
✨ fix + test for #124
35f751f
jvdd added a commit that referenced this issue Oct 22, 2022
@jvdd
Merge pull request #127 from predict-idlab/fix_max_samples
9bd29d6 
✨  fix + test for #124
@jvdd jvdd changed the title max_n_samples, seems to do nothing with plotly-resampler=0.8.1 max_n_samples in add trace(s) seems to do nothing with plotly-resampler=0.8.1 Oct 22, 2022
@jvdd
Copy link
Member

jvdd commented Oct 22, 2022

Solved in #127

@jvdd jvdd closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasvdd jonasvdd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvdd @jonasvdd