Skip to content

tz-aware datetime pd.Series. -> tz information gets lost #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
jonasvdd opened this issue May 11, 2023 · 0 comments · Fixed by #211
Closed
2 tasks done

tz-aware datetime pd.Series. -> tz information gets lost #210

jonasvdd opened this issue May 11, 2023 · 0 comments · Fixed by #211
Assignees
@jonasvdd
Labels
bug Something isn't working

Comments

@jonasvdd
Copy link
Member

jonasvdd commented May 11, 2023 •
edited
Loading

When passing a tz-aware non pd.DateTimeIndex (and thus not a pd.Series) to hf_x the .values is performed internally when parsing the hf_data kwargs; which removes the time-zone information; and will display the UTC time.

image

image

TODO:

  • write tests
  • test what happens when we alter hf_data[<ID>]['x'] at runtime with a tz-aware pd.DateTimeIndex
@jonasvdd jonasvdd added the bug Something isn't working label May 11, 2023
@jonasvdd jonasvdd self-assigned this May 11, 2023
jonasvdd added a commit that referenced this issue May 11, 2023
@jonasvdd
✨ tests for #210
aef4263
jonasvdd added a commit that referenced this issue May 11, 2023
@jonasvdd
💪 code-fix for #210
299bcb1
jonasvdd added a commit that referenced this issue May 11, 2023
@jonasvdd
🔧 tests for setting hf_x dynamically for #210
d2ad175
@jonasvdd jonasvdd mentioned this issue May 11, 2023
Merged
jonasvdd added a commit that referenced this issue May 12, 2023
@jonasvdd @jvdd
Fixes #210 (#211)
a14331e 
* 💪 add tests for #208

* 🙏 fix for #208

* ✨ tests for #210

* 💪 code-fix for #210

* 🔧 tests for setting hf_x dynamically for #210

* 🔥 fix for setting hf_series x to a tz-aware pd.Series

* 🖊️ review

* 🔍 review code

* 🔍 fix helper method

* 🙏

---------

Co-authored-by: jvdd <[email protected]>
jonasvdd added a commit that referenced this issue May 12, 2023
@jonasvdd @jvdd
Fixes #210 (#211)
84a79fd 
* 💪 add tests for #208

* 🙏 fix for #208

* ✨ tests for #210

* 💪 code-fix for #210

* 🔧 tests for setting hf_x dynamically for #210

* 🔥 fix for setting hf_series x to a tz-aware pd.Series

* 🖊️ review

* 🔍 review code

* 🔍 fix helper method

* 🙏

---------

Co-authored-by: jvdd <[email protected]>
jonasvdd added a commit that referenced this issue May 14, 2023
@jonasvdd @jvdd
Log support (#207)
4157229 
* 🍌 formatting

* 💨 first version of log axis support

* 🙈 fix tests

* 🔧 adresses #190 and #205

* 🙈 formatting

* Datetime bugfix (#209)

* 💪 add tests for #208

* 🙏 fix for #208

* Fixes #210 (#211)

* 💪 add tests for #208

* 🙏 fix for #208

* ✨ tests for #210

* 💪 code-fix for #210

* 🔧 tests for setting hf_x dynamically for #210

* 🔥 fix for setting hf_series x to a tz-aware pd.Series

* 🖊️ review

* 🔍 review code

* 🔍 fix helper method

* 🙏

---------

Co-authored-by: jvdd <[email protected]>

* 🔍 review

* 🖊️ review code

* ✨ improve docs + add rangeindex log test

* 💨 fix test + add example

* 🔍 review code

---------

Co-authored-by: jvdd <[email protected]>
Co-authored-by: Jeroen Van Der Donckt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasvdd jonasvdd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #210 predict-idlab/plotly-resampler
1 participant
@jonasvdd